Skip to content

fix: eliminate storyboard atlas overflow GPU stalls + bump framework to 2026.503.7 - #297

Merged
winnerspiros merged 2 commits into
masterfrom
copilot/fix-vulkan-texture-issues
May 3, 2026
Merged

fix: eliminate storyboard atlas overflow GPU stalls + bump framework to 2026.503.7#297
winnerspiros merged 2 commits into
masterfrom
copilot/fix-vulkan-texture-issues

Conversation

Copilot AI commented May 3, 2026

Copy link
Copy Markdown

During gameplay load on Android Vulkan, DrawableStoryboard was creating a regular atlased TextureStore. Storyboard assets (large per-beatmap images) immediately exhaust the 2048×2048 atlas, producing 8+ overflow events in ~5 seconds — each allocating a fresh 16 MB GPU texture and firing a vkQueueSubmit, stalling the render thread. Confirmed in logs: all 8 overflows occur within the PlayerLoader entry window.

Changes

  • DrawableStoryboard.cs — replace the per-storyboard TextureStore (atlased) with LargeTextureStore. Storyboard assets are large, single-use, per-beatmap images; atlas packing provides zero batching benefit and causes repeated overflow stalls. Also drops the incorrect scaleAdjust: 1 override that was forcing uploads at 1× physical resolution regardless of DPI.
// before
new TextureStore(host.Renderer, host.CreateTextureLoaderStore(
    CreateResourceLookupStore()
), false, scaleAdjust: 1)

// after
new LargeTextureStore(host.Renderer, host.CreateTextureLoaderStore(
    CreateResourceLookupStore()
))

LargeTextureStore : TextureStore, so [Resolved] TextureStore in DrawableStoryboardSprite / DrawableStoryboardAnimation continues to resolve correctly with no other changes needed.

Copilot AI and others added 2 commits May 3, 2026 17:18
…verflow stalls

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/cb1742a5-5c06-4dba-983f-8df10ba7c05a

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/c07cb0c5-07ba-4616-aac1-b57867c55166

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
@winnerspiros
winnerspiros marked this pull request as ready for review May 3, 2026 17:44
Copilot AI review requested due to automatic review settings May 3, 2026 17:44
@winnerspiros
winnerspiros merged commit e5c16ce into master May 3, 2026
18 checks passed
@gitar-bot

gitar-bot Bot commented May 3, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

Copilot AI removed the request for review from Copilot May 3, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants